Add workflows settings in start node

[wintonzheng]

Important

Add workflow settings to the start node, enabling configuration of webhookCallbackUrl, proxyLocation, and persistBrowserSession.

• Behavior:
  • Add webhookCallbackUrl, proxyLocation, and persistBrowserSession settings to the start node in StartNode.tsx.
  • Update RunWorkflowForm, CreateNewTaskForm, and SavedTaskForm to include proxyLocation and persistBrowserSession settings.
  • Modify getRunWorkflowRequestBody() in RunWorkflowForm.tsx to handle new settings.
• Workflow Editor:
  • Update FlowRenderer and WorkflowEditor to handle new workflow settings.
  • Add getWorkflowSettings() in workflowEditorUtils.ts to extract settings from nodes.
• Types:
  • Add WorkflowSettings type in workflowTypes.ts and workflowYamlTypes.ts.
  • Update StartNodeData in types.ts to include workflow settings.
• Misc:
  • Add className prop to ProxySelector component.

^{This description was created by for f9a7156. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Incremental review on f9a7156 in 1 minute and 21 seconds

More details

• Looked at 669 lines of code in 13 files
• Skipped 0 files when reviewing.
• Skipped posting 6 drafted comments based on config settings.

1. skyvern-frontend/src/components/ProxySelector.tsx:16

• Draft comment:
  Consider providing a default value for the className prop to avoid potential styling issues if it's not provided.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The ProxySelector component is missing a default value for the className prop. This could lead to unexpected styling issues if the prop is not provided.

2. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:518

• Draft comment:
  The className prop for ProxySelector is consistently set to w-48 across multiple files. Ensure this width is appropriate for all use cases.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The ProxySelector component is used in multiple files with the className prop set to w-48. This is consistent across CreateNewTaskForm.tsx, SavedTaskForm.tsx, and RunWorkflowForm.tsx. Ensure this width is appropriate for all use cases.

3. skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx:690

• Draft comment:
  The className prop for ProxySelector is consistently set to w-48 across multiple files. Ensure this width is appropriate for all use cases.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The ProxySelector component is used in multiple files with the className prop set to w-48. This is consistent across CreateNewTaskForm.tsx, SavedTaskForm.tsx, and RunWorkflowForm.tsx. Ensure this width is appropriate for all use cases.

4. skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx:114

• Draft comment:
  Ensure that initialSettings provides the correct default values for webhookCallbackUrl and proxyLocation.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The RunWorkflowForm component initializes webhookCallbackUrl and proxyLocation from initialSettings. This ensures that the form starts with the correct default values.

5. skyvern-frontend/src/routes/workflows/WorkflowRunParameters.tsx:99

• Draft comment:
  Ensure that ProxyLocation.Residential and an empty string are the intended default values for proxyLocation and webhookCallbackUrl, respectively.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The WorkflowRunParameters component sets default values for proxyLocation and webhookCallbackUrl using ProxyLocation.Residential and an empty string, respectively. This is consistent with other parts of the code.

6. skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx:279

• Draft comment:
  Ensure that getWorkflowSettings correctly extracts the intended settings from nodes.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The FlowRenderer component uses getWorkflowSettings to extract settings from nodes. This ensures that the workflow settings are correctly retrieved and used.

Workflow ID: wflow_OpXk0buHiMBORwGe

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to f9a7156 in 1 minute and 54 seconds

More details

• Looked at 669 lines of code in 13 files
• Skipped 0 files when reviewing.
• Skipped posting 5 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/editor/WorkflowEditor.tsx:10

• Draft comment:
  Remove unused import ProxyLocation.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The import statement for ProxyLocation is not used in this file. Removing unused imports is a good practice to keep the code clean and maintainable.

2. skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx:40

• Draft comment:
  Remove unused import ProxyLocation.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The import statement for ProxyLocation is not used in this file. Removing unused imports is a good practice to keep the code clean and maintainable.

3. skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/StartNode.tsx:10

• Draft comment:
  Remove unused import ProxyLocation.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The import statement for ProxyLocation is not used in this file. Removing unused imports is a good practice to keep the code clean and maintainable.

4. skyvern-frontend/src/routes/workflows/editor/nodes/StartNode/types.ts:1

• Draft comment:
  Remove unused import ProxyLocation.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The import statement for ProxyLocation is not used in this file. Removing unused imports is a good practice to keep the code clean and maintainable.

5. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:82

• Draft comment:
  Remove unused import ProxyLocation.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The import statement for ProxyLocation is not used in this file. Removing unused imports is a good practice to keep the code clean and maintainable.

Workflow ID: wflow_Ovv6oshF08kVdmfG

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.