Add scrollable for nodes panel #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add scrollable functionality to `WorkflowNodeLibraryPanel.tsx` using `ScrollArea` and `ScrollAreaViewport`. > > - **UI Enhancement**: > - Adds `ScrollArea` and `ScrollAreaViewport` to `WorkflowNodeLibraryPanel.tsx` to make the node library panel scrollable. > - Sets maximum height of `ScrollAreaViewport` to `28rem` to limit the visible area and enable scrolling. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for c98b5d5dfe8e81f5eb78c25651f758785a8ddf4f. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ae52c3e in 12 seconds
More details
- Looked at
105lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowNodeLibraryPanel.tsx:16
- Draft comment:
EnsureScrollAreaandScrollAreaViewportare correctly implemented inscroll-areamodule. - Reason this comment was not posted:
Confidence changes required:50%
The import statement forScrollAreaandScrollAreaViewportis correct and matches the usage in the component. However, it's important to ensure that these components are correctly implemented in thescroll-areamodule.
Workflow ID: wflow_T3Wa8zhZ8n5JBKN8
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ae52c3e in 14 seconds
More details
- Looked at
105lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowNodeLibraryPanel.tsx:16
- Draft comment:
EnsureScrollAreaandScrollAreaViewportare correctly implemented and styled inui/scroll-area. - Reason this comment was not posted:
Confidence changes required:50%
The import statement forScrollAreaandScrollAreaViewportis correct, but we should ensure that these components are properly implemented and styled in theui/scroll-areamodule.
Workflow ID: wflow_VIK9xJVYdqzBP6cS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds scrollable functionality to
WorkflowNodeLibraryPanel.tsxusingScrollAreaandScrollAreaViewportfor improved UI.ScrollAreaandScrollAreaViewporttoWorkflowNodeLibraryPanel.tsxto make the node library panel scrollable.ScrollAreaViewportto28remto limit the visible area and enable scrolling.This description was created by
for ae52c3e. It will automatically update as commits are pushed.