Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor normal select #1237

Merged
merged 2 commits into from
Nov 22, 2024
Merged

refactor normal select #1237

merged 2 commits into from
Nov 22, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 22, 2024

Important

Refactor normal_select in handler.py to enhance option selection using LLM API and add new prompt template normal-select.j2.

  • Behavior:
    • Refactor normal_select in handler.py to use LLM API for option selection, adding parameters dom, task, and step.
    • Remove FailToSelectByLabel exception handling in handler.py.
  • Prompts:
    • Add normal-select.j2 template for generating selection prompts based on user context and options.
  • Logging:
    • Change logging from LOG.error to LOG.info in normal_select for click failures and selection attempts.

This description was created by Ellipsis for 275bd71. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 275bd71 in 27 seconds

More details
  • Looked at 201 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:809
  • Draft comment:
    The FailToSelectByLabel exception handling has been removed. Consider adding it back to handle cases where selection by label fails, as this could aid in debugging and understanding failures.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.
2. skyvern/webeye/actions/handler.py:2241
  • Draft comment:
    The logging level has been changed from error to info for several log messages. Consider whether these should remain as error to ensure visibility in case of failures. This applies to other similar changes in the file as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The refactoring in normal_select function has changed the logging level from error to info for several log messages. This might reduce the visibility of these logs in case of failures, as error logs are typically more visible than info logs.

Workflow ID: wflow_O3RuPHGYPYpI4S5d


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 26a9f67 into main Nov 22, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/refactor-normal-select branch November 22, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant