Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extraction block bug #1232

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix extraction block bug #1232

merged 1 commit into from
Nov 21, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 21, 2024

Important

Fixes logic in agent_step() to correctly handle ValidationBlock tasks without a navigation goal.

  • Bug Fix:
    • Fixes logic in agent_step() in agent.py to correctly handle tasks of type ValidationBlock.
    • Ensures CompleteAction is not created for ValidationBlock tasks without a navigation goal.

This description was created by Ellipsis for f06c1e3. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f06c1e3 in 12 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/agent.py:635
  • Draft comment:
    The condition if not task.navigation_goal and not isinstance(task_block, ValidationBlock): is correct, but it can be simplified for better readability. Consider using a single line for the condition check.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the condition is correct, but the logic can be simplified for better readability.

Workflow ID: wflow_BU7MjNKujfViao62


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 23479af into main Nov 21, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-extract-block-bug branch November 21, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant