Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit auto completion trigger #1223

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 20, 2024

Important

Added a condition in handle_input_text_action to limit auto-completion trigger to non-raw input elements in handler.py.

  • Behavior:
    • In handle_input_text_action, added a condition to check await skyvern_element.is_raw_input() before triggering auto-completion logic.
    • Auto-completion logic now only executes if the element is not a raw input.
  • Misc:
    • Indented existing code under the new condition to limit execution scope.

This description was created by Ellipsis for 6808353. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 6808353 in 34 seconds

More details
  • Looked at 66 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_QJ74iU25s928ECok


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

skyvern/webeye/actions/handler.py Show resolved Hide resolved
@LawyZheng LawyZheng merged commit c777e3d into main Nov 20, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/limit-auto-completion-trigger branch November 20, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant