Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force checkbox input to be visible #1203

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 15, 2024

Important

Update isElementVisible in domUtils.js to check parent visibility for checkbox inputs, similar to radio inputs.

  • Behavior:
    • Update isElementVisible in domUtils.js to check parent visibility for input elements of type checkbox, similar to radio inputs.

This description was created by Ellipsis for 49c6ec5. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 49c6ec5 in 13 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/scraper/domUtils.js:250
  • Draft comment:
    Ensure that the logic for checking visibility of checkbox inputs is consistent with other input types. The change here is correct and aligns with the existing logic for radio inputs.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the PR is straightforward and correct. It adds a condition to check for checkbox inputs, similar to radio inputs, ensuring their visibility is determined by their parent element. This is consistent with the existing logic for radio inputs.

Workflow ID: wflow_NCrNba5yGRwpFrzV


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit b678ec3 into main Nov 15, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/force-checkbox-input-visible branch November 15, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant