Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to convert css shape to string shape by LLM log should be warning #1197

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Nov 15, 2024

Important

Change logging level from exception to warning in _convert_css_shape_to_string() for CSS shape conversion failures.

  • Logging:
    • Change logging level from exception to warning in _convert_css_shape_to_string() in agent_functions.py when CSS shape conversion fails.

This description was created by Ellipsis for d5cd169. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d5cd169 in 7 seconds

More details
  • Looked at 18 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/agent_functions.py:254
  • Draft comment:
    Using exc_info=True with LOG.warning is not typical and might not be necessary. Consider removing exc_info=True unless the traceback is needed for a warning log.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from LOG.exception to LOG.warning is appropriate given the context. However, the use of exc_info=True with LOG.warning is not typical and might not be necessary.

Workflow ID: wflow_KaHjKjEPWPMqVpiD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit b2516dc into main Nov 15, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/make_css_conversion_failure_log_warning branch November 15, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant