make task block title empty string by default; use task_block.label for the running task.title if task_block.title is empty #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Default task title changed to empty string, using label if title is empty in `TaskBlock` and `TaskBlockYAML`. > > - **Behavior**: > - In `agent.py`, `create_task_and_step_from_block()` now uses `task_block.label` if `task_block.title` is empty. > - **Models**: > - In `block.py`, `TaskBlock` default `title` changed from "Untitled Task" to an empty string. > - In `yaml.py`, `TaskBlockYAML` default `title` changed from "Untitled Task" to an empty string. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 0f4f66b817165e2cfafe3f8415b79176e52e3854. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 0f139d3 in 18 seconds
More details
- Looked at
41lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/agent.py:134
- Draft comment:
Ensure thattask_block.labelis always available and non-empty to avoid potential issues whentask_block.titleis empty. - Reason this comment was not posted:
Confidence changes required:50%
The change in the PR is to set the default title of TaskBlock and TaskBlockYAML to an empty string and use the label if the title is empty. This change is correctly implemented in the code.
Workflow ID: wflow_Ki5mEaU7cAMGBCa6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0f139d3 in 20 seconds
More details
- Looked at
41lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/agent.py:134
- Draft comment:
Ensuretask_block.labelis always available whentask_block.titleis empty to avoid potential issues. This change is correctly implemented here. - Reason this comment was not posted:
Confidence changes required:20%
The change inagent.pyto usetask_block.labeliftask_block.titleis empty is correctly implemented. However, the default title inTaskBlockandTaskBlockYAMLis set to an empty string, which aligns with the PR description.
Workflow ID: wflow_pL6AA3ZmmVgokMFI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Default task title changed to empty string, using label if title is empty in
TaskBlockandTaskBlockYAML.agent.py,create_task_and_step_from_block()now usestask_block.labeliftask_block.titleis empty.block.py,TaskBlockdefaulttitlechanged from "Untitled Task" to an empty string.yaml.py,TaskBlockYAMLdefaulttitlechanged from "Untitled Task" to an empty string.This description was created by
for 0f139d3. It will automatically update as commits are pushed.