Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make all the timestamp local time and hovering shows UTC timestamp #1164

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Nov 11, 2024

Tested locally:
<img width="1230" alt="Screenshot 2024-11-11 at 2 24 54 AM" src="https://github.com/user-
Screenshot 2024-11-11 at 2 24 36 AM
attachments/assets/a5c31a1f-f741-4e8f-a1a6-3cb5c78f569f">
Screenshot 2024-11-11 at 2 24 47 AM

Screenshot 2024-11-11 at 2 24 30 AM Screenshot 2024-11-11 at 2 25 11 AM

Important

Timestamps are now displayed in local time with UTC shown on hover across various components, using updated time formatting functions.

  • Behavior:
    • Timestamps now display in local time using basicLocalTimeFormat() and show UTC on hover using title attribute with basicTimeFormat().
    • Affects components like StepArtifacts, StepInfo, TaskHistory, QueuedTasks, RunningTasks, WorkflowPage, WorkflowRun, Workflows, and LastRunAtTime.
  • Functions:
    • Adds basicLocalTimeFormat() to timeFormat.ts for local time formatting.
    • Updates basicTimeFormat() to include 'UTC' in the output string.
  • Components:
    • StepArtifacts.tsx, StepInfo.tsx, TaskHistory.tsx, QueuedTasks.tsx, RunningTasks.tsx, WorkflowPage.tsx, WorkflowRun.tsx, Workflows.tsx, LastRunAtTime.tsx updated to use new time formatting functions.

This description was created by Ellipsis for bef947d. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to bef947d in 1 minute and 21 seconds

More details
  • Looked at 299 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/util/timeFormat.ts:3
  • Draft comment:
    Ensure the input time string is in a valid ISO 8601 format before manipulating it. The current approach of appending 'Z' might lead to incorrect results if the input is not UTC.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_BzXZTbeQxspTM96F


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 068535b into main Nov 11, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/make_timestamp_all_local_with_title_utc branch November 11, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants