-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overflow of default value in parameters #1156
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add scrollable areas to `WorkflowParameterAddPanel` and `WorkflowParameterEditPanel` to handle content overflow. > > - **UI Enhancement**: > - Added `ScrollArea` and `ScrollAreaViewport` to `WorkflowParameterAddPanel.tsx` and `WorkflowParameterEditPanel.tsx` to handle overflow of content. > - Ensures UI remains usable with many parameters or long descriptions by making the panels scrollable. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 8aafeb4c7dc7868273d5ec9712d58023d975f3c4. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on d1f2f68 in 25 seconds
More details
- Looked at
1021
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterAddPanel.tsx:70
- Draft comment:
Consider refactoring the repeated logic for handling different parameter types into separate functions or components to improve maintainability and reduce redundancy. This pattern is repeated in WorkflowParameterEditPanel as well. - Reason this comment was not posted:
Confidence changes required:50%
The code in both WorkflowParameterAddPanel and WorkflowParameterEditPanel has a repeated pattern for handling different parameter types. This can be refactored to improve maintainability and reduce redundancy.
2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx:111
- Draft comment:
Consider refactoring the repeated logic for handling different parameter types into separate functions or components to improve maintainability and reduce redundancy. This pattern is repeated in WorkflowParameterAddPanel as well. - Reason this comment was not posted:
Confidence changes required:50%
The code in both WorkflowParameterAddPanel and WorkflowParameterEditPanel has a repeated pattern for handling different parameter types. This can be refactored to improve maintainability and reduce redundancy.
Workflow ID: wflow_Ja05yyhk08HzaOUc
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to d1f2f68 in 50 seconds
More details
- Looked at
1021
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterAddPanel.tsx:238
- Draft comment:
Consider refactoring the JSON parsing logic into a utility function to avoid code repetition and improve readability. This pattern is repeated in WorkflowParameterEditPanel.tsx as well. - Reason this comment was not posted:
Confidence changes required:50%
The code in both WorkflowParameterAddPanel.tsx and WorkflowParameterEditPanel.tsx has a repeated pattern for handling JSON default values. This can be refactored into a utility function to improve code readability and maintainability.
2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx:279
- Draft comment:
Consider refactoring the JSON parsing logic into a utility function to avoid code repetition and improve readability. This pattern is repeated in WorkflowParameterAddPanel.tsx as well. - Reason this comment was not posted:
Confidence changes required:50%
The code in both WorkflowParameterAddPanel.tsx and WorkflowParameterEditPanel.tsx has a repeated pattern for handling JSON default values. This can be refactored into a utility function to improve code readability and maintainability.
Workflow ID: wflow_ctYmSqU8y5YPVzDx
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add scrollable areas to
WorkflowParameterAddPanel.tsx
andWorkflowParameterEditPanel.tsx
to handle content overflow.ScrollArea
andScrollAreaViewport
toWorkflowParameterAddPanel.tsx
andWorkflowParameterEditPanel.tsx
to handle content overflow.This description was created by for d1f2f68. It will automatically update as commits are pushed.