fix angular select bug (#831)

Skyvern-AI · Sep 16, 2024 · 8d0b044 · 8d0b044
1 parent 8c2a733
commit 8d0b044
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/skyvern/webeye/scraper/domUtils.js b/skyvern/webeye/scraper/domUtils.js
@@ -418,8 +418,10 @@ function isInteractable(element) {
     return true;
   }
 
-  if (tagName === "div" && hasAngularClickBinding(element)) {
-    return true;
+  if (tagName === "div" || tagName === "span") {
+    if (hasAngularClickBinding(element)) {
+      return true;
+    }
   }
 
   // support listbox and options underneath it
@@ -562,12 +564,7 @@ const isAngularDropdown = (element) => {
   }
 
   const tagName = element.tagName.toLowerCase();
-  // TODO: some angular might use <span> to trigger dropdown menu
-  // if (tagName === "span") {
-  //   ...
-  // }
-
-  if (tagName === "input") {
+  if (tagName === "input" || tagName === "span") {
     const ariaLabel = element.hasAttribute("aria-label")
       ? element.getAttribute("aria-label").toLowerCase()
       : "";