Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed user and password from pypi-release.yml #298

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Keira-Crafts
Copy link
Contributor

I'm creating this PR because we're introducing GitHub Actions as a trusted publisher to the cfripper library. Here, we're making an update to the pypi-release workflow so we remove the username and password as this is not needed.

Copy link
Contributor

@marcsantamaria-sky marcsantamaria-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Trusted publisher added in pypi
image

@Keira-Crafts Keira-Crafts merged commit 97304e3 into master Aug 22, 2024
8 checks passed
@Keira-Crafts Keira-Crafts deleted the trusted-publishers branch August 22, 2024 12:45
@Keira-Crafts Keira-Crafts mentioned this pull request Aug 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants