-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store the hashed ApplicationSet Spec inside the ProgressiveSync state manager #135
Conversation
@@ -0,0 +1,6377 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taken from https://github.com/argoproj-labs/applicationset/blob/v0.2.0/manifests/crds/argoproj.io_applicationsets.yaml as it is needed for our tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments but generally looks good!
Usage: argocd [flags] argocd [command] Available Commands: account Manage account settings app Manage applications cert Manage repository certificates and SSH known hosts entries cluster Manage cluster credentials completion output shell completion code for the specified shell (bash or zsh) context Switch between contexts gpg Manage GPG keys used for signature verification help Help about any command login Log in to Argo CD logout Log out from Argo CD proj Manage projects relogin Refresh an expired authenticate token repo Manage repository connection parameters repocreds Manage repository connection parameters version Print version information Flags: --auth-token string Authentication token --client-crt string Client certificate file --client-crt-key string Client certificate key file --config string Path to Argo CD config (default "/Users/dimitarhristov/.argocd/config") --grpc-web Enables gRPC-web protocol. Useful if Argo CD server is behind proxy which does not support HTTP2. --grpc-web-root-path string Enables gRPC-web protocol. Useful if Argo CD server is behind proxy which does not support HTTP2. Set web root. -H, --header strings Sets additional header to all requests made by Argo CD CLI. (Can be repeated multiple times to add multiple headers, also supports comma separated headers) -h, --help help for argocd --insecure Skip server certificate and domain verification --logformat string Set the logging format. One of: text|json (default "text") --loglevel string Set the logging level. One of: debug|info|warn|error (default "info") --plaintext Disable TLS --port-forward Connect to a random argocd-server port using port forwarding --port-forward-namespace string Namespace name which should be used for port forwarding --server string Argo CD server address --server-crt string Server certificate file Use "argocd [command] --help" for more information about a command. as a parameter
Co-authored-by: Matteo Ruina <matteo.ruina@gmail.com>
Co-authored-by: Matteo Ruina <matteo.ruina@gmail.com>
Co-authored-by: Matteo Ruina <matteo.ruina@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, introduces a hash annotation that parses the AppSet and produces a unique hash, and detects a change on the deployment content like that.
The hash is stored in the in-memory store for now.
Background
This PR will contribute and help us toward achieving - #63
Changes
get
andlist
ApplicationSet objects;github.com/argoproj-labs/applicationset
as a dependency;applicationset
as part of the controller scheme;Testing
Outstanding tasks