project.assets.json processing #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichielOda
requested changes
Nov 3, 2023
| private bool ShouldSkipPackage(LockFileTargetLibrary library) | ||
| { | ||
| // In dev packs, the Newtonsoft.Json and SharpZipLib packages were added as dependencies but only for runtime.. | ||
| if(String.Equals(library.Name, "Newtonsoft.Json", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Won't this exclude Newtonsoft even when added directly to the project?
There was a problem hiding this comment.
this code checks if newntonsoft package was added next to the dev back (and will include it if this is the case) because for the dev pack it will only add it to the runtime entry (as we defined that as such in the nuspec for the dev pack)
| if (assemblyFound == null) | ||
| return true; | ||
| } | ||
| else if(String.Equals(library.Name, "SharpZipLib", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Same comment as for Newtonsoft
There was a problem hiding this comment.
same applies for this package as for Newtonsoft
|
Closing this PR until we would need it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#12182
AB#12183