-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slayers] Adds Slayer Bossbars #940
Conversation
Should cover #908 |
2385c5f
to
8760809
Compare
8760809
to
f7dd132
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the render mixin is necessary. I would add it to BossBarHud#bossBars
and remove it when you set the bar to null. The current implementation also stops any other bars from rendering.
src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerBossBars.java
Outdated
Show resolved
Hide resolved
I mixin'd on render to be able to explictly cancel other bars from rendering. I originally had it to just appened a bar but people disliked multiple bars in the video i demo'd it in, thus i mixin'd to render to cancel any 'quest' bars for the duration of the fight |
Ok, I'll just make some naming and formatting fixes then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks!
Note
Squash please
Slayer Bossbars innit