[Location Share & Waypoint] Share position and set waypoint #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might actually put this on the backburner. This would be a great contender for the websocket work that's been done, and this should only really be relied upon for interop with other mods |
LifeIsAParadox
added
merge conflicts
BigloBot
force-pushed
the
share-location-waypoints
branch
from
2f08082 to
937b29f
Compare
LifeIsAParadox
added
reviews needed
kevinthegreat1
requested changes
Aug 20, 2024
src/main/java/de/hysky/skyblocker/skyblock/chat/chatcoords/ChatLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/chat/chatcoords/ChatLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/chat/chatcoords/ChatWaypointLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/waypoint/IndividualWaypoint.java
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
|
@kevinthegreat1 this was very much hacked together in about 10 mins for someone just wanting it for this diana, I wasn't realy meaning to leave this for actual review 🙏 I'll make sure to get these changes done though at some point |
|
@BigloBot you can subclass |
BigloBot
force-pushed
the
share-location-waypoints
branch
from
8d08d82 to
950edef
Compare
LifeIsAParadox
added
reviews needed
kevinthegreat1
requested changes
Aug 24, 2024
src/main/java/de/hysky/skyblocker/skyblock/chat/chatcoords/ChatWaypointLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/chat/chatcoords/ChatLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/utils/waypoint/NamedWaypoint.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
BigloBot
force-pushed
the
share-location-waypoints
branch
from
950edef to
ed13bda
Compare
LifeIsAParadox
added
reviews needed
BigloBot
force-pushed
the
share-location-waypoints
branch
2 times, most recently
from
b412e7a to
bd5154b
Compare
AzureAaron
added
the
merge conflicts
kevinthegreat1
force-pushed
the
share-location-waypoints
branch
from
bd5154b to
246661c
Compare
LifeIsAParadox
removed
the
merge conflicts
kevinthegreat1
approved these changes
Sep 5, 2024
LifeIsAParadox
added
merge me please
Fluboxer
pushed a commit
to Fluboxer/Skyblocker
that referenced
this pull request
Sep 8, 2024
…erMod#916) Co-authored-by: Kevinthegreat <92656833+kevinthegreat1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link your position in chat
Set waypoint from shared position