Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slot Text Stuff #1134

Merged
merged 5 commits into from
Feb 27, 2025
Merged

Slot Text Stuff #1134

merged 5 commits into from
Feb 27, 2025

Conversation

AzureAaron
Copy link
Collaborator

  • HOTM Perk Level Slot Text (Implements HoTM levels display #1130)
  • Add Discrite as an evolving item
  • Replace magic values for colours with constants
    • Wasn't sure what to name the blue colours but I guess its fine for now and can be changed later

@AzureAaron AzureAaron added documentation Improvements or additions to documentation new feature This issue or PR is a new feature labels Jan 12, 2025
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jan 12, 2025
@AzureAaron AzureAaron linked an issue Jan 12, 2025 that may be closed by this pull request
HoTM levels display #1130
Closed
Emirlol
Emirlol previously requested changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@Emirlol Emirlol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About time someone refactored them into constants lol

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes reviews needed This PR needs reviews and removed reviews needed This PR needs reviews changes requested This PR need changes labels Jan 12, 2025
@AzureAaron AzureAaron added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Jan 12, 2025
@AzureAaron AzureAaron added merge conflicts This PR has merge conflicts that need solving. and removed changes requested This PR need changes labels Jan 26, 2025
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge conflicts This PR has merge conflicts that need solving. labels Feb 4, 2025
@LifeIsAParadox LifeIsAParadox mentioned this pull request Feb 18, 2025
Closed
kevinthegreat1
kevinthegreat1 previously approved these changes Feb 20, 2025
View reviewed changes
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Feb 20, 2025
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge me please Pull requests that are ready to merge labels Feb 22, 2025
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Feb 27, 2025
@kevinthegreat1 kevinthegreat1 merged commit 37422ac into SkyblockerMod:master Feb 27, 2025
2 checks passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

@Emirlol Emirlol Emirlol left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation new feature This issue or PR is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HoTM levels display
4 participants
@AzureAaron @Emirlol @kevinthegreat1 @LifeIsAParadox