Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to share fairy grottos #1072

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

No description provided.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Dec 10, 2024
@@ -111,6 +111,9 @@ public static class CrystalsWaypoints {

@SerialEntry
public boolean wishingCompassSolver = true;

@SerialEntry
public boolean shareFairyGrotto = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really should be off by default.

Copy link
Collaborator

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People who don't want to share fairy grottos shouldn't receive them either. If you want to take you have to give as well.

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Dec 10, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Dec 12, 2024
@kevinthegreat1
Copy link
Collaborator Author

Updated. Not tested, however.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Dec 12, 2024
@AzureAaron AzureAaron merged commit e0559a5 into SkyblockerMod:master Dec 13, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants