Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add math teacher helper #1041

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented Nov 1, 2024

Appends the result and a clickable green text to the math teacher's calculation, calculated using the Calculator class.

image

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Nov 1, 2024
@Emirlol Emirlol added new feature This issue or PR is a new feature small change Small changes that are easier to review and removed reviews needed This PR needs reviews labels Nov 1, 2024
@viciscat
Copy link
Collaborator

viciscat commented Nov 1, 2024

math too hard 😔

@Fluboxer
Copy link
Contributor

Fluboxer commented Nov 1, 2024

May as well go extra step and send it for user in chat - iirc this is how 1.8.9 mods do it
(do same for speaking demon)

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Nov 1, 2024
viciscat
viciscat previously approved these changes Nov 1, 2024
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume you tested it and that no NPE can occur

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Nov 1, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge me please Pull requests that are ready to merge labels Nov 1, 2024
@Emirlol
Copy link
Collaborator Author

Emirlol commented Nov 1, 2024

i assume you tested it and that no NPE can occur

My testing wasn't extensive, but logic-wise it should be covered. And if the calculation fails, it should silently fail and not do anything.

kevinthegreat1
kevinthegreat1 previously approved these changes Nov 1, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Nov 1, 2024
@Fluboxer
Copy link
Contributor

Fluboxer commented Nov 1, 2024

Since we are just in time, can you also make it solve public speaking demon (send something long enough in chat) and commitment phobia (clicking anywhere with open chat would run command that signing paper does)?

изображение

@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge me please Pull requests that are ready to merge labels Nov 1, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Nov 1, 2024
@kevinthegreat1 kevinthegreat1 merged commit 83c31b2 into SkyblockerMod:master Nov 1, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Nov 1, 2024
@Emirlol Emirlol deleted the primal-fear-helper branch November 2, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature small change Small changes that are easier to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants