Feat: Adds PATCH & DELETE and Improve client types #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethsandaru
changed the title
tuanlc
reviewed
Aug 22, 2023
Antman261
approved these changes
Aug 22, 2023
tuanlc
approved these changes
Aug 22, 2023
swkyyme
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 things that are being introduced in this PR
Adds PATCH, DELETE
Up to now, RESTFul is still popular and widely used worldwide, thus
PATCH&DELETEshould be added. This would increase the package compatibility with userland's approaches.Parse the response body
Before, we blindly accept the response body and directly return it to userland.
There is a small issue if we have
Date.Express will always transform the JS
Dateinstances to strings (utilizing the toISOString)On the client side, we thought that we would have the correct
Dateinstance but it isn't.So adds logic to pick up the schema definition from the given method & path and parse the response body. This will ensure we have the correct response body & types before doing anything else.
Thank you.