Support for merged cells and hyperlinks in Excel template #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example: the block [fieldName;ope=mergecells;rows=xx;cols=yy] is used to merge cells from xx rows and yy columns. One of the parameters (`rows` or `cols`) can be omitted, and its value would be read from `fieldName`.
Reference to existing merged cells are read in TbsLoadSubFileAsTemplate(), and are updated in BeforeMergeBlock() to match their new position after adding rows/columns. Finally, they are written in BeforeShow() to the current subfile.
|
Hi, will this ever get merged? |
|
I think they forgot about this PR
… Message ID: ***@***.***>
|
|
Maybe send a ping to @Skrol29. This is a really needed feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyperlinks in Excel template are recorded in element. This PR adds support for keeping updated correctly when rows/cells are added as a result of the calls to
MergeBlock.Merged cells in Excel template are records in element. This PR adds similar support for element.
This kind of support only works for merged cells and hyperlinks that are not in the same row as the row that has
block=tbs:row(and similarly, not in the same column as the column that hasblock=tbs:cell).A new ope was introduced to support this case, that's
ope=mergecells.Example:
block=tbs:row, a cell withope=mergecells;cols=2would generate a merged cell (containing 2 columns) in each added rowblock=tbs:cell, a cell withope=mergecells;rows=3would generate a merged cell (containing 3 rows) in each added columnParameters
rowsandcolscan be omitted. The default value is the value of the current field. This feature allows the dimensions of the merged cell to be determined dynamically.Example:
block=tbs:row, a cell with[block1.field2;ope=mergecells;rows=1]andblock1.field2has value 4 would generate a merged cell (containing 4 columns) in each added rowblock=tbs:cell, a cell with[block1.field2;ope=mergecells;cols=1]andblock1.field2has value 5 would generate a merged cell (containing 5 rows) in each added column