Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression Skull Owner #5698

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Expression Skull Owner #5698

merged 3 commits into from
Jul 1, 2024

Conversation

NotSoDelayed
Copy link
Contributor

Description

This PR adds skull owner expression into Skript!
Javadocs:

Target Minecraft Versions: any
Requirements: -
Related Issues: -

AyhamAl-Ali
AyhamAl-Ali requested changes May 15, 2023
View reviewed changes
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR ⚡

src/main/java/ch/njol/skript/expressions/ExprSkullOwner.java Show resolved Hide resolved
@AyhamAl-Ali AyhamAl-Ali added the feature Pull request adding a new feature. label May 15, 2023
TheLimeGlass
TheLimeGlass previously requested changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@TheLimeGlass TheLimeGlass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skript already has ItemType set block with Skull, but this allows to properly get the username of the skull without parsing the itemtype skull of LimeGlass

src/main/java/ch/njol/skript/expressions/ExprSkullOwner.java Outdated Show resolved Hide resolved
@Moderocky Moderocky force-pushed the master branch 2 times, most recently from bd134d0 to 3f08853 Compare September 16, 2023 16:59
sovdeeth
sovdeeth approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Ayham's request, looks good.

@sovdeeth sovdeeth added the 2.9 Targeting a 2.9.X version release label Mar 19, 2024
@sovdeeth sovdeeth requested a review from TheLimeGlass June 28, 2024 16:00
@sovdeeth sovdeeth changed the base branch from master to dev/feature June 28, 2024 16:00
@Moderocky Moderocky added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jul 1, 2024
@APickledWalrus APickledWalrus added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Jul 1, 2024
@APickledWalrus APickledWalrus merged commit b226c8b into SkriptLang:dev/feature Jul 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@AyhamAl-Ali AyhamAl-Ali AyhamAl-Ali approved these changes

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

@TheLimeGlass TheLimeGlass Awaiting requested review from TheLimeGlass

Assignees
No one assigned
Labels
2.9 Targeting a 2.9.X version release feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NotSoDelayed @sovdeeth @Moderocky @TheLimeGlass @AyhamAl-Ali @APickledWalrus