Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings and add clippy ci check #168

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Fix clippy warnings and add clippy ci check #168

merged 2 commits into from
Feb 28, 2022

Conversation

Skallwar
Copy link
Owner

  • misc: Run clippy and fixes all warnings
  • ci: Add clippy check

@Skallwar Skallwar requested a review from CohenArthur January 22, 2022 15:57
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #168 (5409f49) into master (422b810) will increase coverage by 0.41%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   64.32%   64.73%   +0.41%     
==========================================
  Files          17       17              
  Lines         625      621       -4     
==========================================
  Hits          402      402              
+ Misses        223      219       -4     
Impacted Files Coverage Δ
src/disk.rs 0.00% <0.00%> (ø)
src/scraper.rs 23.07% <14.28%> (+0.37%) ⬆️
src/downloader.rs 71.69% <80.00%> (+0.67%) ⬆️
src/url_helper.rs 100.00% <100.00%> (ø)

Copy link
Collaborator

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@CohenArthur CohenArthur merged commit 2357697 into master Feb 28, 2022
@CohenArthur CohenArthur deleted the fix_clippy branch February 28, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants