Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single pipeline for images. #321

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Use a single pipeline for images. #321

merged 2 commits into from
Apr 5, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Removes the copy-only pipeline for images without commands to fix #316

@JimBobSquarePants JimBobSquarePants added this to the v3.0.0 milestone Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #321 (2fece11) into main (cc2fa1a) will increase coverage by 0%.
The diff coverage is 86%.

@@         Coverage Diff         @@
##           main   #321   +/-   ##
===================================
  Coverage    85%    85%           
===================================
  Files        83     83           
  Lines      2375   2371    -4     
  Branches    346    346           
===================================
- Hits       2026   2024    -2     
+ Misses      245    244    -1     
+ Partials    104    103    -1     
Flag Coverage Δ
unittests 85% <86%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 83% <85%> (+1%) ⬆️
...harp.Web/Middleware/ImageSharpMiddlewareOptions.cs 93% <100%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants merged commit a31a461 into main Apr 5, 2023
@JimBobSquarePants JimBobSquarePants deleted the js/issue-316 branch April 5, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OnBeforeSaveAsync called only when there are available Commands which is not correct in some scenarios
1 participant