Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Imagesharp v3 #305

Merged
merged 39 commits into from
Mar 5, 2023
Merged

Update to Imagesharp v3 #305

merged 39 commits into from
Mar 5, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Updates the ImageSharp reference to v3 nightlies and perform API updates and cleanup.

@JimBobSquarePants JimBobSquarePants added this to the v3.0.0 milestone Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #305 (bc1e923) into main (d91883f) will decrease coverage by 1%.
The diff coverage is 84%.

@@         Coverage Diff         @@
##           main   #305   +/-   ##
===================================
- Coverage    85%    85%   -1%     
===================================
  Files        76     77    +1     
  Lines      2166   2192   +26     
  Branches    300    304    +4     
===================================
+ Hits       1855   1877   +22     
- Misses      230    231    +1     
- Partials     81     84    +3     
Flag Coverage Δ
unittests 85% <84%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...geSharp.Web.Providers.AWS/AmazonS3ClientFactory.cs 31% <0%> (ø)
src/ImageSharp.Web/AsyncHelper.cs 100% <ø> (ø)
src/ImageSharp.Web/Caching/HexEncoder.cs 100% <ø> (ø)
src/ImageSharp.Web/Caching/LegacyV1CacheKey.cs 100% <ø> (ø)
...hing/LruCache/LongTickCountLruItem{TKey,TValue}.cs 90% <ø> (ø)
...ching/LruCache/TLruLongTicksPolicy{TKey,TValue}.cs 21% <ø> (ø)
src/ImageSharp.Web/Caching/UriAbsoluteCacheKey.cs 100% <ø> (ø)
...p.Web/Caching/UriAbsoluteLowerInvariantCacheKey.cs 100% <ø> (ø)
src/ImageSharp.Web/Caching/UriRelativeCacheKey.cs 100% <ø> (ø)
...p.Web/Caching/UriRelativeLowerInvariantCacheKey.cs 100% <ø> (ø)
... and 52 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants merged commit e852621 into main Mar 5, 2023
@JimBobSquarePants JimBobSquarePants deleted the js/imagesharpV3 branch March 5, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants