Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop on cache file read error. #264

Merged
merged 1 commit into from
May 18, 2022

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Pass the missed true parameter to the Invoke method to allow retrying a command while allowing a short-circuit.

See #257 for a reference.

@JimBobSquarePants JimBobSquarePants added this to the v2.0.1 milestone May 18, 2022
@JimBobSquarePants JimBobSquarePants requested a review from a team May 18, 2022 10:38
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #264 (7062618) into main (607c6a9) will decrease coverage by 0%.
The diff coverage is 0%.

@@         Coverage Diff         @@
##           main   #264   +/-   ##
===================================
- Coverage    85%    85%   -1%     
===================================
  Files        75     75           
  Lines      2036   2036           
  Branches    298    298           
===================================
- Hits       1741   1739    -2     
- Misses      211    213    +2     
  Partials     84     84           
Flag Coverage Δ
unittests 85% <0%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ImageSharp.Web/Middleware/ImageSharpMiddleware.cs 81% <0%> (ø)
.../Synchronization/RefCountedConcurrentDictionary.cs 72% <0%> (-4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607c6a9...7062618. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit 80d1578 into main May 18, 2022
@JimBobSquarePants JimBobSquarePants deleted the js/retry-shortcircuit-fix branch May 18, 2022 10:51
@ronaldbarendse ronaldbarendse mentioned this pull request May 18, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants