Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line recognition #246

Merged
merged 6 commits into from
Feb 26, 2022
Merged

Conversation

steffi3011
Copy link
Contributor

@steffi3011 steffi3011 commented Feb 24, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Add line recognition to determine the number of rows needed in the generated layout.

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this submission @steffi3011 I really appreciate the assistance.

It looks like we're missing unit tests plus there's some StyleCop issues. I've also provided suggestion for the intellisense documentation.

Please let me know if you need help with anything.

src/SixLabors.Fonts/TextMeasurer.cs Outdated Show resolved Hide resolved
src/SixLabors.Fonts/TextMeasurer.cs Outdated Show resolved Hide resolved
steffi3011 and others added 3 commits February 25, 2022 14:55
Co-authored-by: James Jackson-South <james_south@hotmail.com>
Co-authored-by: James Jackson-South <james_south@hotmail.com>
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #246 (70e25b9) into main (b9cb37e) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #246   +/-   ##
===================================
  Coverage    84%    84%           
===================================
  Files       182    182           
  Lines      8933   8938    +5     
  Branches   1420   1420           
===================================
+ Hits       7526   7531    +5     
  Misses     1083   1083           
  Partials    324    324           
Flag Coverage Δ
unittests 84% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SixLabors.Fonts/TextMeasurer.cs 89% <100%> (+<1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9cb37e...70e25b9. Read the comment docs.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks for your help 👍

@JimBobSquarePants JimBobSquarePants merged commit 0856c1f into SixLabors:main Feb 26, 2022
@steffi3011
Copy link
Contributor Author

You are welcome.
Could you tell me when a new version with this feature will be released?

@JimBobSquarePants
Copy link
Member

It’s available in our MyGet feed now. We don’t have a timeframe for the next NuGet release

@steffi3011
Copy link
Contributor Author

For us, this new version with this special feature would be very important. Maybe it is possible to make the NuGet release as soon as possible?

@JimBobSquarePants
Copy link
Member

@steffi3011 Does your company have a SixLabors License?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants