[Personalize][Initializers] Move XP tracking API examples to separate add-on initializer #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
suggested changes
Apr 14, 2022
There was a problem hiding this comment.
Looking good, see some comments.
Overall, I'm noticing we still have a lot of duplicated code in Layout.tsx accross initializers. We are duplicating to include either <VisitorIdentification/> or <CdpIntegrationScript/> as follows:
<VisitorIdentification/>should be added when nextjs-styleguide-tracking is included<CdpIntegrationScript/>should be added when nextjs-personalize is included
Maybe we need a new abstraction here (similar to <Navigation />?) that makes these inclusions independent of Layout.tsx?
Note we should have more flexibility with in this PR.
We will also need to apply same treatment to nextjs-sxa add-on.
packages/create-sitecore-jss/src/initializers/nextjs-personalize/index.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/initializers/nextjs-styleguide-tracking/index.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/initializers/nextjs-styleguide-tracking/index.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/initializers/nextjs-styleguide-tracking/index.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/initializers/nextjs/prompts.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-styleguide-tracking/data/dictionary/en.yml
Show resolved
Hide resolved
ambrauer
reviewed
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
inquirer, dave into source code of other libs which implement controls)nextjs-styleguidenextjs-styleguide-trackingandnextjs-personalizeare created togethernextjs-styleguide-trackingis created withoutnextjs-styleguide/trackingpageScriptscomponent in order to do not duplicateLayoutcomponentTesting Details
Types of changes