Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Initializers] Add merge (concatenate) functionality for .env files (part 2) #959

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

ambrauer
Copy link
Contributor

Description / Motivation

If the .env values already exist in the target .env file (e.g. an add-on is initialized more than once), don't concatenate the file contents.

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

… an add-on is initialized more than once), don't concatenate the file contents.
@ambrauer ambrauer requested a review from a team March 18, 2022 19:16
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@illiakovalenko illiakovalenko merged commit 7044a26 into dev Mar 21, 2022
@illiakovalenko illiakovalenko deleted the feature/522564-env-merge-dups branch March 21, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants