Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Fix redirects with defaultLocale set to 'default' #2055

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Mar 17, 2025

Description / Motivation

Fix an endless redirect issue with [/default/(.*) -> /en/$1] redirect rule when nextjs default locale is set to default.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team March 17, 2025 23:06
@art-alexeyenko art-alexeyenko changed the title [sitecore-jss-nextjs] Fix redirects with dafaultLocale set to 'default' [sitecore-jss-nextjs] Fix redirects with defaultLocale set to 'default' Mar 17, 2025
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@art-alexeyenko art-alexeyenko merged commit acfa78b into dev Mar 18, 2025
1 check passed
@art-alexeyenko art-alexeyenko deleted the bugfix/jss-5203-default-locale branch March 18, 2025 15:48
yavorsk pushed a commit that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants