Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Fix a more specific redirect rule with locale not activating #2054

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Mar 17, 2025

Description / Motivation

Fixes an issue where a more specific redirect rule (i.e. matching pl-PL/path) is not activating when a less specific rule is present (/path).

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team March 17, 2025 22:50
@art-alexeyenko art-alexeyenko changed the title [sitecore-jss-nextjs] Fix a more specific resirect rule with locale not activating [sitecore-jss-nextjs] Fix a more specific redirect rule with locale not activating Mar 17, 2025
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!
see one suggestion for renaming.
approved in advance.

…-5373-redirects-locales

# Conflicts:
#	CHANGELOG.md
#	packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts
@art-alexeyenko art-alexeyenko merged commit dec14b0 into dev Mar 18, 2025
1 check passed
@art-alexeyenko art-alexeyenko deleted the bugfix/jss-5373-redirects-locales branch March 18, 2025 17:07
yavorsk pushed a commit that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants