-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nextjs] Move ComponentLibrary from a separate route to Layout.tsx #2053
[Nextjs] Move ComponentLibrary from a separate route to Layout.tsx #2053
Conversation
I think there are missing changes to |
packages/create-sitecore-jss/src/templates/nextjs-sxa/src/Layout.tsx
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-sxa/src/Layout.tsx
Outdated
Show resolved
Hide resolved
…, redirect to root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor comments for your consideration, and please make sure azure pipeline completes.
Regardles, approved. Good job and well done Addy.
Description / Motivation
Customers typically customize catch-all route and
Layout.tsx
with various things like React contexts.That mean they need to re-apply those modification on the
DesignLibrary
route too, which makes user experience worse.component-library/render
file route and now redirectd to/
ComponentLibraryLayout
toDesignLibrary
for distinction of Layouts and all related utils and functions.Layout.tsx
which now handles the rendering ofDesignLibrary
based onrenderingType
Testing Details
Types of changes