Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Angular] Edge Proxy / Context Id support #1875

Merged
merged 8 commits into from
Aug 8, 2024
Merged

[Angular] Edge Proxy / Context Id support #1875

merged 8 commits into from
Aug 8, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Aug 7, 2024 •
edited
Loading

Description / Motivation

  • [React][Angular][Vue][Next.js] Fixed an issue when environment variable is undefined, that produced an "undefined" value in temp/config file
  • Moved sitecoreApikey "no-api-key-set" fallback value to disconnected mode plugin, otherwise we always have a default value, that is needed only for disconnected mode
  • Updated scripts/update-graphql-fragment-data.ts to use clientFactory instead of isomorphic-fetch
  • Updated GraphQLDictionaryService to use site query when XM Cloud is used
  • Introduced getGraphQLClientFactoryConfig function as a single source of all the resolved config properties

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team August 7, 2024 13:45
ambrauer
ambrauer approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See a couple minor comments. Otherwise, approved, looks great!

packages/create-sitecore-jss/src/templates/angular-sxp/scripts/config/plugins/disconnected.ts Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular/src/app/lib/graphql-client/client-factory.ts Outdated Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit 60ddc3f into dev Aug 8, 2024
1 check was pending
@illiakovalenko illiakovalenko deleted the feature/JSS-3546 branch August 8, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer