Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-dev-tools] [Nextjs] [React] Introduce "components" configuration for ComponentBuilder #1598

Merged
merged 2 commits into from
Aug 22, 2023
Merged

[sitecore-jss-dev-tools] [Nextjs] [React] Introduce "components" configuration for ComponentBuilder #1598

merged 2 commits into from
Aug 22, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Aug 22, 2023 •
edited
Loading

Description / Motivation

  • Introduced a new components property for ComponentBuilder in order to be able to bring custom components that can be placed under a specific path that doesn't match the default one.
  • Added a new components plugin (react, next), where you can configure the components property.

Testing Details

  • Unit Test Added
  • Manual Test/Other - tested using disconnected mode, by providing custom components

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team August 22, 2023 10:43
ambrauer
ambrauer approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 👍

@ambrauer ambrauer merged commit 6a753e6 into dev Aug 22, 2023
@ambrauer ambrauer deleted the feature/JSS-427 branch August 22, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer