Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js][Multisite] GraphQLSiteInfoService does not fetch more than 10 sites #1569

Merged
merged 2 commits into from
Jul 21, 2023
Merged

[Next.js][Multisite] GraphQLSiteInfoService does not fetch more than 10 sites #1569

merged 2 commits into from
Jul 21, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jul 21, 2023 •
edited
Loading

Description / Motivation

  • Use pagination to prefetch all the sites
  • For consistency, added pageSize property as a part of the config

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team July 21, 2023 09:47
ambrauer
ambrauer approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit be58a29 into dev Jul 21, 2023
@ambrauer ambrauer deleted the bugfix/JSS-204 branch July 21, 2023 13:37
@ambrauer ambrauer linked an issue Jul 21, 2023 that may be closed by this pull request
Multisite only works with 10 sites #1565
Closed
@ambrauer ambrauer mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multisite only works with 10 sites
2 participants
@illiakovalenko @ambrauer