Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nextjs] Fix double placeholder in Experience Editor in production mode #1557

Merged
merged 3 commits into from
Jul 13, 2023
Merged

[nextjs] Fix double placeholder in Experience Editor in production mode #1557

merged 3 commits into from
Jul 13, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Jul 12, 2023 •
edited
Loading

Remove workaround from bug 540957 (#1161) that addressed placeholder hydration errors.
This will bring back hydration console errors when using jss connected mode in rendering host, but will get rid of issues when using rendering host in production mode instead (which is a better tradeoff).

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania
Copy link
Contributor Author

addy-pathania commented Jul 12, 2023 •
edited
Loading

@ambrauer Replying you regrading your comment HERE --> Doesn't seems so, since this work around was added just to get rid of hydration errors.

@addy-pathania addy-pathania requested a review from ambrauer July 12, 2023 22:43
ambrauer
ambrauer approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit f25d085 into dev Jul 13, 2023
@ambrauer ambrauer deleted the bug/587850-double-placeholder branch July 13, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @ambrauer