[sitecore-jss-react] Remove use of reactDom/server from React Image
#1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addy-pathania
changed the title
reactDom/server from client bundle
addy-pathania
changed the title
reactDom/server from client bundlereactDom/server from react Image
addy-pathania
changed the title
reactDom/server from react ImagereactDom/server from React Image
|
@sc-addypathania Great finding! |
illiakovalenko
requested changes
Jun 30, 2023
|
@sc-addypathania Don't forget to close related issue #1280 and leave the comment there |
illiakovalenko
requested changes
Jul 5, 2023
illiakovalenko
requested changes
Jul 6, 2023
| if (!imgAttrs) { | ||
| return getEditableWrapper(imageField.editable); | ||
| } | ||
|
|
||
| const imgHtml = ReactDOMServer.renderToStaticMarkup(<img {...imgAttrs} />); | ||
| const imgHtml = `<img ${getAttributesString( | ||
| imgAttrs as { [key: string]: string | number | boolean | Record<string, unknown> } |
There was a problem hiding this comment.
To simplify this cast action, the getAttributesString can accept { [key: string]: unknown }. In this case, you don't need to cast the type, and I'm not sure that it will make getAttributesString more complex, it also can accept the same type
There was a problem hiding this comment.
Hmm yes you're right. This simplified it.
illiakovalenko
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
reactDom/server'srenderStaticMarkupfunction with a custom template literals forimgHtmlasreactDom/serverbloated the client bundle size of the app.Description / Motivation
Testing Details
Types of changes