Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#585891: fixed 404/500 added DISABLE_SSG_FETCH params #1496

Merged
merged 3 commits into from
May 25, 2023
Merged

#585891: fixed 404/500 added DISABLE_SSG_FETCH params #1496

merged 3 commits into from
May 25, 2023

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented May 24, 2023 •
edited
Loading

Description / Motivation

Added condition DISABLE_SSG_FETCH for 404/500 pages to enable full ISR (Incremental Static Regeneration) flow

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer merged commit 7657f76 into dev May 25, 2023
@ambrauer ambrauer deleted the bugfix/585891-fixed-404-500 branch May 25, 2023 19:56
@bewards
Copy link

bewards commented Jun 6, 2023

What is the headLinks code for? I see this code in the commit, but looks like the release package somehow omits it.

@illiakovalenko
Copy link
Contributor

@bewards headLinks part it's a feature that will be released in JSS 21.2. The latest release doesn't contain that

@illiakovalenko
Copy link
Contributor

illiakovalenko commented Jun 6, 2023 •
edited
Loading

@bewards I referenced this PR since I pulled changes from here, but actual commit for patch is: 66a032a

@bewards
Copy link

bewards commented Jun 6, 2023

Thanks for the clarification @illiakovalenko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

@illiakovalenko illiakovalenko Awaiting requested review from illiakovalenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sc-ruslanmatkovskyi @bewards @illiakovalenko @ambrauer