Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js][Personalize] Unique Identifier Scope #1494

Merged
merged 9 commits into from
May 24, 2023
Merged

[Next.js][Personalize] Unique Identifier Scope #1494

merged 9 commits into from
May 24, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented May 23, 2023 •
edited
Loading

Description / Motivation

This PR introduces personalize scope identifier, to isolate embedded personalization data among XMC environments that are sharing a Personalize tenant

Testing Details

  • Unit Test Added
  • Manual Test/Other - Scaffolded nextjs, nextjs-personalize, nextjs-styleguide and tested personalization with/without scope value

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team May 23, 2023 06:20
art-alexeyenko
art-alexeyenko approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good!
I only have one comment/question below

packages/sitecore-jss/src/personalize/utils.ts Outdated Show resolved Hide resolved
ambrauer
ambrauer reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a bunch of language/product suggestions for public comments

CHANGELOG.md Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-personalize/.env Outdated Show resolved Hide resolved
packages/sitecore-jss/src/personalize/graphql-personalize-service.ts Outdated Show resolved Hide resolved
packages/sitecore-jss/src/personalize/utils.ts Outdated Show resolved Hide resolved
illiakovalenko and others added 5 commits May 24, 2023 16:27
@illiakovalenko @ambrauer
Update CHANGELOG.md description
6fadbc5 
Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
@illiakovalenko @ambrauer
Update packages/sitecore-jss/src/personalize/graphql-personalize-serv…
d5fbb61 
…ice.ts

Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
@illiakovalenko @ambrauer
Update packages/sitecore-jss/src/personalize/utils.ts
a14feb0 
Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
@illiakovalenko @ambrauer
Update packages/create-sitecore-jss/src/templates/nextjs-personalize/…
ed7a3cf 
….env

Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
@illiakovalenko
Update comment
262eeae
@illiakovalenko illiakovalenko requested a review from ambrauer May 24, 2023 13:30
@illiakovalenko illiakovalenko merged commit e22ddef into dev May 24, 2023
@illiakovalenko illiakovalenko deleted the feature/583663 branch May 24, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illiakovalenko @ambrauer @art-alexeyenko