Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installed sitecore-jss-* dependency version #1478

Merged
merged 4 commits into from
May 12, 2023
Merged

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented May 12, 2023

When trying to scaffold a JSS app with a specific patch version the sitecore-jss-* dependencies jump to the next minor version which is unexpected.

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania changed the title Fix sitecore-jss-* versions for all templates Fix installed sitecore-jss-* dependency version May 12, 2023
@addy-pathania addy-pathania changed the title Fix installed sitecore-jss-* dependency version Fix installed sitecore-jss-* dependency version May 12, 2023
@addy-pathania addy-pathania requested a review from a team May 12, 2023 15:31
@addy-pathania addy-pathania linked an issue May 12, 2023 that may be closed by this pull request
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update all inter-package dependencies (e.g. these).

@addy-pathania addy-pathania requested a review from ambrauer May 12, 2023 16:24
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sc-addypathania Please update lock file (checks are failing)

@addy-pathania addy-pathania merged commit ac980bd into dev May 12, 2023
@addy-pathania addy-pathania deleted the bug/584823 branch May 12, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSS package incompatability with older versions
2 participants