Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/530504: [middleware-redirects] fixed defines query string #1460

Merged
merged 1 commit into from
May 2, 2023

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Apr 28, 2023

Description / Motivation

Fixed defines query string and added additional condition for locale of site

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/530504-fixed-redirects-with-qs branch 2 times, most recently from 7b8b768 to 42cd965 Compare April 28, 2023 12:45
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG entry. Otherwise, looks good!

@ambrauer
Copy link
Contributor

ambrauer commented May 1, 2023

Please add a CHANGELOG entry. Otherwise, looks good!

@matkovskyi and also looks like there are now conflicts.

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/530504-fixed-redirects-with-qs branch 2 times, most recently from bf175a5 to ef52af3 Compare May 2, 2023 10:38
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/530504-fixed-redirects-with-qs branch from ef52af3 to 79a994c Compare May 2, 2023 11:30
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit 6302177 into dev May 2, 2023
@ambrauer ambrauer deleted the bugfix/530504-fixed-redirects-with-qs branch May 2, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants