Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#577960: [SXA] fixed middleware redirects #1431

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Apr 12, 2023

Description / Motivation

Fixed regex middleware redirects.
Worked differently than on SXA MVC version.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm wondering regarding unit tests, should something be adjusted?

@sc-ruslanmatkovskyi
Copy link
Collaborator Author

Looks good to me. I'm wondering regarding unit tests, should something be adjusted?

I've tried add unit test when we use nextJS 12 but there were errors about "process" and etc. So I discussed with Adam about it and we decided skip this test. But I can to try to add unit test again something later.

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/577960-fixed-middleware-redirect branch from fa2479f to 349467c Compare April 13, 2023 11:44
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/577960-fixed-middleware-redirect branch from 349467c to 38a373f Compare April 13, 2023 11:54
@illiakovalenko illiakovalenko merged commit 4283f94 into dev Apr 13, 2023
@illiakovalenko illiakovalenko deleted the bugfix/577960-fixed-middleware-redirect branch April 13, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants