Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js] Fix for Link component which throws error if field is undefined #1425

Merged
merged 2 commits into from
Apr 10, 2023
Merged

[Next.js] Fix for Link component which throws error if field is undefined #1425

merged 2 commits into from
Apr 10, 2023

Conversation

ambrauer
Copy link
Contributor

@ambrauer ambrauer commented Apr 7, 2023 •
edited
Loading

Description / Motivation

  • Fixes an issue with nextjs Link component where build throws TypeError when field is undefined
  • Also added a couple additional tests for editing use cases

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

ambrauer added 2 commits April 7, 2023 13:17
@ambrauer
Fix issue with nextjs Link component where build throws TypeError whe…
fb554f1 
…n field is undefined. Also added a couple additional tests for editing use cases.
@ambrauer
CHANGELOG update
f2a5e03
@ambrauer ambrauer force-pushed the fix/569418-missing-next-link-field branch from 20070c8 to f2a5e03 Compare April 7, 2023 18:19
@ambrauer ambrauer requested a review from a team April 7, 2023 18:19
illiakovalenko
illiakovalenko approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@illiakovalenko illiakovalenko merged commit 5e8ee37 into dev Apr 10, 2023
@illiakovalenko illiakovalenko deleted the fix/569418-missing-next-link-field branch April 10, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ambrauer @illiakovalenko