[sitecore-jss-react] Fix rendering issue in components using withPlaceholder #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/sitecore-jss-react/src/enhancers/withPlaceholder.test.tsx
Outdated
Show resolved
Hide resolved
illiakovalenko
pushed a commit
that referenced
this pull request
Mar 14, 2023
…eholder (#1349) * fix placeholderCommon, add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the rendering issueWhen additional params are configured in sitecore, the the components using the withPlaceholder HOC crashes because the current implementation of PlaceholderCommon assumes that the params would always be present on any rendering which is not the case as it is an optional property.
Description / Motivation
Testing Details
Types of changes