Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] Fix Vue production build #1313

Merged
merged 1 commit into from
Jan 31, 2023
Merged

[Vue] Fix Vue production build #1313

merged 1 commit into from
Jan 31, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Jan 31, 2023 •
edited
Loading

Downgraded html-loader version possibly because of the breaking changes introduced with latest version as it migrates to use esModule.

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team January 31, 2023 00:00
illiakovalenko
illiakovalenko approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@addy-pathania addy-pathania merged commit 3510631 into dev Jan 31, 2023
@addy-pathania addy-pathania deleted the bugfix/570404-vue-prod-fail branch January 31, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @illiakovalenko