Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-proxy] Disable websocket processing by default in proxy #1311

Merged
merged 1 commit into from
Jan 31, 2023
Merged

[sitecore-jss-proxy] Disable websocket processing by default in proxy #1311

merged 1 commit into from
Jan 31, 2023

Conversation

art-alexeyenko
Copy link
Contributor

[sitecore-jss/sitecore-jss-proxy] Better handling for WebSocket requests.

  • Makes proxy handling of WebSocket requests configurable
  • Adds ws property via ProxyConfig
  • Makes it disabled by default

Testing Details

Manual testing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team January 30, 2023 18:53
@art-alexeyenko art-alexeyenko changed the title Disable websocket processing by default Disable websocket processing by default in proxy Jan 30, 2023
illiakovalenko
illiakovalenko approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illiakovalenko illiakovalenko changed the title Disable websocket processing by default in proxy [sitecore-jss-proxy] Disable websocket processing by default in proxy Jan 31, 2023
@illiakovalenko illiakovalenko merged commit 9b5c873 into dev Jan 31, 2023
@illiakovalenko illiakovalenko deleted the bug/proxy-reject-websocket branch January 31, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @illiakovalenko