Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular] upgrade bootstrap in sample app #1308

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jan 27, 2023

  • Upgrades bootstrap to v5.2 in angular sample app
  • Adds resolutions to avoid rules skip during build
  • Tweaks CSS to match changes in bootstrap v5

Known issue:

  • You may get the following error when building angular sample app in monorepo setup:
    ** Rules skipped due to selector errors: legend+* -> Cannot read property 'type' of undefined
    to avoid it, add resolutions for css-select into the monorepo's root package:
  "resolutions": {
    "css-select": "4.2.1"
  }

You can read more in here: GoogleChromeLabs/critters#103

Testing Details

Manual testing for build and CSS on angular sample.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team January 27, 2023 17:54
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@art-alexeyenko art-alexeyenko merged commit 892f5b2 into dev Jan 27, 2023
@art-alexeyenko art-alexeyenko deleted the feature/angular-bootstrap branch January 27, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants