Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements for personalize service and middleware #1218

Merged
merged 10 commits into from
Nov 4, 2022
Merged

Performance improvements for personalize service and middleware #1218

merged 10 commits into from
Nov 4, 2022

Conversation

art-alexeyenko
Copy link
Contributor

Description / Motivation

  1. Memory cache usage added to personalize graphql service to cut the number of requests to Sitecore Edge endpoint.
  2. Personalize middleware will be disabled by default in development environment - the disabled() delegate passed to middleware still can be changed when needed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team October 27, 2022 20:50
illiakovalenko
illiakovalenko requested changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a test case which validates that when cache timeout is finished it should return expected data from the API
Like here: https://github.com/Sitecore/jss/blob/dev/packages/sitecore-jss/src/i18n/rest-dictionary-service.test.ts#L87-L142
Otherwise looks good 👍

packages/sitecore-jss/src/personalize/graphql-personalize-service.ts Outdated Show resolved Hide resolved
art-alexeyenko and others added 2 commits November 2, 2022 10:46
@art-alexeyenko @ambrauer
Update packages/sitecore-jss/src/personalize/graphql-personalize-serv…
67c2800 
…ice.ts

Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
@art-alexeyenko
rename cache field
5d0def3
@ambrauer ambrauer mentioned this pull request Nov 2, 2022
Merged
illiakovalenko
illiakovalenko requested changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments below, but in general looks good

packages/sitecore-jss/src/personalize/graphql-personalize-service.test.ts Outdated Show resolved Hide resolved
packages/sitecore-jss/src/personalize/graphql-personalize-service.test.ts Outdated Show resolved Hide resolved
packages/sitecore-jss/src/personalize/graphql-personalize-service.test.ts Outdated Show resolved Hide resolved
ambrauer
ambrauer approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@art-alexeyenko art-alexeyenko merged commit ad0d767 into dev Nov 4, 2022
@art-alexeyenko art-alexeyenko deleted the feature/personalize-performance branch November 4, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@art-alexeyenko @ambrauer @illiakovalenko