Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss] Undefined AbortController #1084

Merged
merged 2 commits into from
Jun 30, 2022
Merged

[sitecore-jss] Undefined AbortController #1084

merged 2 commits into from
Jun 30, 2022

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Jun 29, 2022 •
edited
Loading

Added AbortController to sitecore-jss package to get rid of the error during next build.

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team June 29, 2022 22:09
ambrauer
ambrauer approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ambrauer ambrauer merged commit a2700e1 into dev Jun 30, 2022
@ambrauer ambrauer deleted the fix/540419-abort-controller-error branch June 30, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @ambrauer