Add typescript to the sample #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xy templates to typescript. Expose ServerBundle interface from sitecore-jss-proxy package
illiakovalenko
requested changes
May 9, 2022
...ages/create-sitecore-jss/src/templates/node-headless-ssr-experience-edge/src/config.types.ts
Outdated
Show resolved
Hide resolved
illiakovalenko
requested changes
May 10, 2022
packages/create-sitecore-jss/src/templates/node-headless-ssr-proxy/tsconfig.json
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/node-headless-ssr-proxy/package.json
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/node-headless-ssr-proxy/package.json
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/node-headless-ssr-proxy/src/config.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/node-headless-ssr-experience-edge/tsconfig.json
Outdated
Show resolved
Hide resolved
...ages/create-sitecore-jss/src/templates/node-headless-ssr-experience-edge/src/config.types.ts
Outdated
Show resolved
Hide resolved
...ages/create-sitecore-jss/src/templates/node-headless-ssr-experience-edge/src/config.types.ts
Outdated
Show resolved
Hide resolved
...ages/create-sitecore-jss/src/templates/node-headless-ssr-experience-edge/src/config.types.ts
Outdated
Show resolved
Hide resolved
...ages/create-sitecore-jss/src/templates/node-headless-ssr-experience-edge/src/config.types.ts
Outdated
Show resolved
Hide resolved
...ages/create-sitecore-jss/src/templates/node-headless-ssr-experience-edge/src/config.types.ts
Outdated
Show resolved
Hide resolved
illiakovalenko
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Testing Details
Manually tested by creating the app and providing jss react/vue template apps.
Types of changes